This repository was archived by the owner on Jan 14, 2025. It is now read-only.
fix: handle description a bit higher in the execution #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimeys
force-pushed
the
client-closed-fixes
branch
from
6a4840d to
0fdb8ba
Compare
jakubadamw
pushed a commit
that referenced
this pull request
Mar 4, 2024
jakubadamw
pushed a commit
that referenced
this pull request
Mar 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, now the issue was we handle column description a bit too early when we moved it after the bind. We should handle these messages when we iterate the row stream, so we actually get some data back from the client.